New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Redis Reactor, fixes #7 #30
Conversation
Wondering if bitmap would be more appropriate for storing these details/metrics in to redis. See related articles: |
Ill check those out, thanks. |
Ok I am starting to understand now. The question I have is can the event data be universally metricized? It seems like it would depend on what the data is and what its being piped through to then calculate a specific metric. I'm thinking that it the |
@jcrugzz Thanks for the pull-request! Here are my thoughts.
Note: In the above all times (2012, 2012-02, etc) would derived from |
@indexzero Yea so there definitely seems to be multiple routes this could go. Since graphite seems to be meant for the time series data (and has built in graphing capabilities which seems sweet), would the best route be to use this reactor to track the active resources? This seems like it would generate the most value. |
@jcrugzz I would say all scenarios are valid. We can add the other ones later. |
@indexzero fair enough. Once this scenario is good to go I'll open up an issue for the others. |
…ustom logic with redis
Converted my changes to a base class that accepts a function in this manner: // Sync
godot.reactor()
.redis(options, function (client, data) {
// Do something with redis
return data;
});
// Async
godot.reactor()
.redis(options, function (client, data, callback) {
// Do something with redis asyncly
process.nextTick(function () {
callback(null, data);
});
}); I should be able to implement those 3 redis use cases in their own reactors inheriting from this. |
Cherry-picked. Thanks! |
Let me know what you think the key should be, a test will also be forthcoming.