-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jruby-complete-9.0.0.0-pre seems to be missing something #2479
Comments
My dist (from Friday afternoon):
fwiw, I am hoping jruby-complete is smaller since was only ship a single version of stdlib and a single parser instead of three. I will not close this until tomorrow when I verify that latest build changes did not break something (some were made on Saturday). |
I have created a test case here https://gist.github.com/monkstone/b5714dbf84431273ec87 which mimics ruby-processing. With jruby-complete-1.7.18.jar ie the following test ruby runner.rb yields the expected result {"JRUBY"=>"false", "PROCESSING_ROOT"=>"/home/tux/processing-3.0a5", "X_OFF"=>192, "Y_OFF"=>108} With jruby-core-9.0.0.0.pre1-complete.jar ie the following test as expected, with runner-pre.rb I get this:-
or similar for ostruct_test (not provided)
perhaps the clue is in the name of the jar in which case my apologies, but I had been assuming that |
use a clean build in case you switch branches or so: anyways it is THE jruby-complete jar, my build shows
the main reason it is bigger than jruby-1.7.18 is the new truffle backend. |
Its a pity that build does not work for me even when preceded by successful git branch |
@monkstone That is an unfortunate side-effect of build system. Any compile errors (which can even be generated classes) will trigger as if there is a compiler error in truffle code. The only way to solve this is to mvn clean first. |
@enebo I routinely do |
wow. I did not read that error very closely...wtf is that massive file name :) @monkstone Can I ask which OS you are trying to build this with? @chrisseaton @nirvdrum @eregon I do not see this on MacOS but perhaps other OSes won't like such long generated filenames? I am not sure this is the base cause of this reported issue or not but I thought I would bring your attention to it. |
I thought we had an issue open for this but apparently not. My guess would be that @monkstone is on Windows - or a unix with some kind of encrypted or FUSE file system? The filename is a little bit ridiculous. I'll see if I can get it fixed so it doesn't try to generate this filename in the first place for Truffle 0.7 (in a few days). |
@chrisseaton Your guess was right about encrypted home directory but it was on linux Mint, I'll have a go on Archlinux instead @enebo and report back (something I had not thought of). |
Yeah an immediate workaround is to use a directory on an unencrypted filesystem if you have one. |
@monkstone can you try building the |
Well now I've booted up into Archlinux (where my user home is not encrypted), compiles OK, and |
OK I think we can close this issue now ruby-processing shader sketches run fine, funny how the incomplete jruby-complete got built in the first place? |
@monkstone If you can verify @chrisseaton truffle-u branch we would love to see if it works with the secure filesystem |
@chrisseaton Your guess was right about encrypted home directory but it was on linux Mint, I'll have a go on Archlinux instead @enebo and report back (something I had not thought of). |
@enebo @chrisseaton Well this is entirely unexpected to me compile of truffle-u branch seems to go OK producing a jruby-complete with same size file 20.5 MB but 'ostruct' and 'psych' are not found as before. |
I wonder if there is some other longs paths causing packaging to not complete successfully but perhaps not crap out over the long paths? |
@monkstone you are basically saying jruby-core and jruby-complete have both the same 20.5MB - sounds the jruby-complete does miss the stdlib files :( - for you |
No! what I am saying is that jruby-complete truffle-u branch compiled on an encrypted file system and master branch jruby-complete compiled on an unencrypted file system are the same size 20.5 MB. Previously rather surprisingly I got 15.6MB on the encrypted system when it actually compiled see first entry.... |
I got confused by jruby-core-9.0.0.0.pre1-complete.jar which NOT jruby-complete and my jruby-complete-9.0.0.0.pre1.jar is about 28MB just in case have a look maven/jruby-complete/target something does not add up not sure what |
I'm now a bit confused but happy to close the issue jruby-complete-9.0.0.0.pre1.jar works OK on both encrypted (compiles OK with truffle-u branch) and unencrypted systems (but jruby-core-9.0.0.0.pre1-complete.jar built on unencrypted system also seemed mostly work for me). @enebo @mkristian @chrisseaton |
sorry - naming things can be quit a challange. the idea was that those "complete" files do not have an further dependencies: jruby-complete-9.0.0.0.pre1 == jruby-core-9.0.0.0.pre1-complete + jruby-stdlib-9.0.0.0.pre1 |
jruby-complete-1.7.18 = 22.4 MB
jruby-complete-9.0.0.0-pre = 15.6 MB
missing 'ostruct' 'fileutils' etc
The text was updated successfully, but these errors were encountered: