Use Enumerable for #map and #to_a in Element

adambeynon · adambeynon · commit 4707d0d4c91a · 2013-08-15T10:43:06.000+01:00
diff --git a/opal/opal-jquery/element.rb b/opal/opal-jquery/element.rb
@@ -247,45 +247,13 @@ def offset
     Hash.from_native(`#{self}.offset()`)
   end
 
-  # Yields each element in #{self} collection in turn. The yielded element
-  # is wrapped as a `DOM` instance.
-  #
-  # @example
-  #
-  #   DOM('.foo').each { |e| puts "The element id: #{e.id}" }
-  #
-  # @return returns the receiver
   def each
     `for (var i = 0, length = #{self}.length; i < length; i++) {`
       yield `$(#{self}[i])`
     `}`
     self
   end
 
-  # return an opal array mapped with block yielded for any element
-  #
-  # @example
-  #
-  #  list = Document.find('table.players td.surname').map  {|el| el.html }
-  #
-  # @return an Array
-  def map
-    list = []
-    each {|el| list << yield(el) }
-    list
-  end
-
-  # return an opal Array of elements
-  #
-  # @example
-  #
-  # Document.find('table.players td.surname').to_a.last
-  #
-  # @return an Array
-  def to_a
-    map {|el| el }
-  end
-
   def first
     `#{self}.length ? #{self}.first() : nil`
   end
diff --git a/spec/element/iterable_spec.rb b/spec/element/iterable_spec.rb
@@ -37,12 +37,12 @@
     it "should return a list of class Array" do
       Element.find('table.players td.surname').to_a.class.should == Array
     end
-    
+
     it "should check first and last element" do
       Element.find('table.players td.surname').to_a.first.html == "rossi"
       Element.find('table.players td.surname').to_a.last.html == "bianchi"
     end
-    
+
     it "should get only element with class surname" do
       Element.find('table.players td').to_a.select {|el| el.has_class?('surname') }.
       map {|el| el.class }.uniq  == ['surname']
