TRUNK-3979: LoggingAdvice should also log which user is performing an ac... #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… action when an error occurs
|
glancing quickly I think you need a null check. also, not every user has a username. use their system id if not. |
| if (logGetter || logSetter) | ||
| log.error("An error occurred while executing this method. Error message: " + t.getMessage(), t); | ||
| if (logGetter || logSetter) { | ||
| String username = Context.getAuthenticatedUser().getUsername(); |
There was a problem hiding this comment.
Can't this Context.getAuthenticatedUser be null? You might want to make the check here too
| if (user == null) { | ||
| username = "Guest (Not logged in)"; | ||
| } else { | ||
| username = Context.getAuthenticatedUser().getUsername(); |
|
I'm not sure that conception is right. I think, LoggingAdvice shouldn't have dependencies to Context and User. |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.openmrs.org/browse/TRUNK-3979