System notice when json_url() retrieves non-existent member

dregad · dregad · commit e1a265c74e6c · 2013-04-27T02:23:06.000+02:00
An additional check and returning false allows caller to handle errors
gracefully.

Fixes #15791
diff --git a/core/json_api.php b/core/json_api.php
@@ -36,17 +36,19 @@
 /**
  * Get a chunk of JSON from a given URL.
  * @param string URL
- * @param string Top-level member to retrieve
- * @return multi JSON class structure
+ * @param string Optional top-level member to retrieve
+ * @return multi JSON class structure, false in case of non-existent member
  */
 function json_url( $p_url, $p_member = null ) {
 	$t_data = url_get( $p_url );
 	$t_json = json_decode( utf8_encode($t_data) );
 
 	if( is_null( $p_member ) ) {
 		return $t_json;
-	} else {
+	} else if( property_exists( $t_json, $p_member ) ) {
 		return $t_json->$p_member;
+	} else {
+		return false;
 	}
 }
 
