Allow selecting any user with privileges when filtering by bug note

rombert · rombert · commit 9b39286bbcba · 2012-09-15T11:14:09.000+03:00
reporter Fix based on patch attached by frodgers at http://www.mantisbt.org/bugs/view.php?id=9725 . Fixes #9725: Filter on "Note By" by a reporter
diff --git a/core/filter_api.php b/core/filter_api.php
@@ -3922,7 +3922,7 @@ function print_filter_note_user_id() {
 					echo '>[' . lang_get( 'myself' ) . ']</option>';
 				}
 
-				print_assign_to_option_list( $t_filter[FILTER_PROPERTY_NOTE_USER_ID] );
+				print_note_option_list( $t_filter[FILTER_PROPERTY_NOTE_USER_ID] );
 			}
 		?>
         </select>
diff --git a/core/print_api.php b/core/print_api.php
@@ -466,6 +466,15 @@ function print_assign_to_option_list( $p_user_id = '', $p_project_id = null, $p_
 	print_user_option_list( $p_user_id, $p_project_id, $p_threshold );
 }
 
+
+function print_note_option_list( $p_user_id = '', $p_project_id = null, $p_threshold = null ) {
+	if ( null === $p_threshold ) {
+		$p_threshold = config_get( 'add_bugnote_threshold' );
+	}
+	
+	print_user_option_list( $p_user_id, $p_project_id, $p_threshold );
+}
+
 /**
  * List projects that the current user has access to.
  *
@@ -776,7 +785,7 @@ function print_enum_string_option_list( $p_enum_name, $p_val = 0 ) {
 	}
 }
 
-/*
+/**
  * Returns a list of valid status options based on workflow
  * @param int $p_user_auth User's access level
  * @param int $p_current_value Current issue's status

Original file line number	Diff line number	Diff line change
`@@ -3922,7 +3922,7 @@ function print_filter_note_user_id() {`
`3922`	`3922`	`echo '>[' . lang_get( 'myself' ) . ']</option>';`
`3923`	`3923`	`}`
`3924`	`3924`
`3925`		`- print_assign_to_option_list( $t_filter[FILTER_PROPERTY_NOTE_USER_ID] );`
	`3925`	`+ print_note_option_list( $t_filter[FILTER_PROPERTY_NOTE_USER_ID] );`
`3926`	`3926`	`}`
`3927`	`3927`	`?>`
`3928`	`3928`	`</select>`
Original file line number	Diff line number	Diff line change
`@@ -466,6 +466,15 @@ function print_assign_to_option_list( $p_user_id = '', $p_project_id = null, $p_`
`466`	`466`	`print_user_option_list( $p_user_id, $p_project_id, $p_threshold );`
`467`	`467`	`}`
`468`	`468`
	`469`	`+`
	`470`	`+function print_note_option_list( $p_user_id = '', $p_project_id = null, $p_threshold = null ) {`
	`471`	`+ if ( null === $p_threshold ) {`
	`472`	`+ $p_threshold = config_get( 'add_bugnote_threshold' );`
	`473`	`+ }`
	`474`	`+`
	`475`	`+ print_user_option_list( $p_user_id, $p_project_id, $p_threshold );`
	`476`	`+}`
	`477`	`+`
`469`	`478`	`/**`
`470`	`479`	`* List projects that the current user has access to.`
`471`	`480`	`*`
`@@ -776,7 +785,7 @@ function print_enum_string_option_list( $p_enum_name, $p_val = 0 ) {`
`776`	`785`	`}`
`777`	`786`	`}`
`778`	`787`
`779`		`-/*`
	`788`	`+/**`
`780`	`789`	`* Returns a list of valid status options based on workflow`
`781`	`790`	`* @param int $p_user_auth User's access level`
`782`	`791`	`* @param int $p_current_value Current issue's status`