Makes fedora 3 datastream content available. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added integration tests and refactored unit tests.
awoods
pushed a commit
that referenced
this pull request
Sep 27, 2013
Makes fedora 3 datastream content available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was that the Connector implementation (Fedora3FederationConnector) failed to override getBinaryValue method. Though the Document returned by this connector (and others) includes an ExternalBinaryValue impelementation as the jcr:data property to the jcr:content document, when it's translated into a node a call is made to the connector to get the ExternalBinaryValue, and if null is returned, silently replaces the existing binary value with an empty one.
This was rather hard to track down, but the fix includes quite a bit of refactoring and improvements to the test rigging.