improved routes command to show which routes are using certain featur…

…es with flags
mojolicious · Feb 14, 2014 · 9b8f60d · 9b8f60d
1 parent e2fe11a
commit 9b8f60d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/Changes b/Changes
@@ -1,6 +1,8 @@
 
 4.81  2014-02-14
   - Added direct array access for child nodes to Mojo::DOM.
+  - Improved routes command to show which routes are using certain features
+    with flags.
 
 4.80  2014-02-13
   - Merged Mojo::DOM::Node into Mojo::DOM.

diff --git a/lib/Mojolicious/Command/routes.pm b/lib/Mojolicious/Command/routes.pm
@@ -26,6 +26,14 @@ sub _walk {
   if (my $i = $depth * 2) { $prefix .= ' ' x $i . '+' }
   push @$rows, my $row = [$prefix . ($route->pattern->pattern || '/')];
 
+  # Flags
+  my @flags;
+  push @flags, $route->inline ? 'B' : '.';
+  push @flags, @{$route->over || []} ? 'C' : '.';
+  push @flags, (my $partial = $route->partial) ? 'D' : '.';
+  push @flags, $route->is_websocket ? 'W' : '.';
+  push @$row, join('', @flags) if $verbose;
+
   # Methods
   my $via = $route->via;
   push @$row, !$via ? '*' : uc join ',', @$via;
@@ -41,8 +49,7 @@ sub _walk {
   my $format = (regexp_pattern($pattern->format_regex || ''))[0];
   my $optional
     = !$pattern->constraints->{format} || $pattern->defaults->{format};
-  $regex .= $optional ? "(?:$format)?" : $format
-    if $format && !$route->partial;
+  $regex .= $optional ? "(?:$format)?" : $format if $format && !$partial;
   push @$row, $regex if $verbose;
 
   $depth++;

diff --git a/lib/Mojolicious/Guides/Routing.pod b/lib/Mojolicious/Guides/Routing.pod
@@ -772,8 +772,8 @@ to list all available routes together with name and underlying regular
 expressions.
 
   $ ./myapp.pl routes -v
-  /foo/:name  GET   fooname  ^/foo/([^/\.]+))(?:\.([^/]+)$)?
-  /bar        POST  bar      ^/bar(?:\.([^/]+)$)?
+  /foo/:name  ....  GET   fooname  ^/foo/([^/\.]+))(?:\.([^/]+)$)?
+  /bar        ....  POST  bar      ^/bar(?:\.([^/]+)$)?
 
 =head1 ADVANCED