New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jpegmeta fixes #381
Jpegmeta fixes #381
Conversation
what |
Think of it as shorthand for, creating a new element and having the function update that new element (see code fragment below). Functions with side-effects on their parameters aren't the clearest, can the function be re-written removing the need for passing parameters by reference? $new_element = null; ... function some_fn_with_side_fx(&$param) { |
@HakanS can you have a look into the _parseXmpNode function and fix $meta[]? or do you have some data that let me test this a bit complete? |
@@ -874,7 +874,7 @@ function save($fileName = "") { | |||
/*************************************************************/ | |||
|
|||
/*************************************************************/ | |||
function _dispose() { | |||
function _dispose($fileName = "") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, how did this even work before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it is never called.
Maybe it could be rewritten as:
This library is kind of shitty. I wish we could replace it with something cleaner. Suggestions welcome. |
Todo:
cannot use [] for reading
at the argument$meta[]
Someone suggestions?
Further there are (i guess) still many possible
Only variables should be assigned by reference
I have no data available to test these stuff, so i cannot finish this properly.