Various things #102
Closed
Various things #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
prakashk
commented
May 6, 2013
prakashk
commented
- replace "\n" with system property so test runs on all platforms
- array.first should return undef when no element satisfies the predicate
- hash.eqv method + tests
- Looks like parser doesn't need the class sigil any more.
- Do not create new scope for each line of code in REPL. (there might be a better way to do this?)
…e a better way to do this?)
|
@prakashk could you remake this pull request but leave out the "Do not create new scope ..." commit, I am not sure that I like that approach. Thanks, Stevan |
|
@stevan: I wan't totally sure about that either. My first approach was even worse :-) I don't see a quick way to remove commits from a pull request or choosing specific commits to create a pull request (github adds all commits in the branch to the request). Using my limited experience with git, I can only think of creating a new branch off master, apply all commits but this one, and push this new branch to create a new pull request. Got any better ideas? Thanks, |
|
@prakashk sorry, no better ideas no. But it should be easy enough to just cherrypick the 7 commits into a new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.