fixed parameter replacement bug in Mojo::Parameters (closes #424)

mojolicious · Dec 4, 2012 · 71fabed · 71fabed
1 parent f755ae2
commit 71fabed
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/Changes b/Changes
@@ -2,6 +2,7 @@
 3.65  2012-12-04
   - Improved documentation.
   - Improved tests.
+  - Fixed parameter replacement bug in Mojo::Parameters. (alexbyk, sri)
 
 3.64  2012-12-01
   - Improved documentation.

diff --git a/lib/Mojo/Parameters.pm b/lib/Mojo/Parameters.pm
@@ -73,6 +73,7 @@ sub params {
   # Replace parameters
   if (@_) {
     $self->{params} = shift;
+    delete $self->{string};
     return $self;
   }
 

diff --git a/t/mojo/parameters.t b/t/mojo/parameters.t
@@ -184,6 +184,11 @@ $params = Mojo::Parameters->new('foo=bar&baz=23');
 $params->parse('foo=bar&baz=23');
 is "$params", 'foo=bar&baz=23', 'right result';
 
+# Replace
+$params = Mojo::Parameters->new('a=1&b=2');
+$params->params([a => 2, b => 3]);
+is $params->to_string, 'a=2&b=3', 'right result';
+
 # Query string
 $params = Mojo::Parameters->new('%AZaz09-._~&;=+!$\'()*,%:@/?');
 is "$params", '%AZaz09-._~&;=+!$\'()*,%:@/?', 'right result';