Treat protected properties as "internal" #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…those defined by mix:lockable.
|
Resolved by: 77a2f6e Addresses: https://www.pivotaltracker.com/story/show/71266232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original thinking was to build a blacklist of properties to hide, but it turned out that it was easier to blacklist all PROTECTED properties with a whitelist of exceptions.
There's one caveat, which is jcr:frozenNodes... right now we just present that content when viewing an old version, but all of the properties are protected. I've added special handling for this case.
This PR includes mostly integration tests to ensure that those properties don't show up.