Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flatiron/director
base: e89b9be7ebea
Choose a base ref
...
head repository: flatiron/director
compare: 8d40862ae127
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Jul 27, 2012

  1. Only use newURL if available (it isn't in IE). 

    This gets the tests passing in IE10 up to test 17, at which point they break and do not continue.
    @domenic
    domenic committed Jul 27, 2012
    Copy the full SHA
    8c12e4e View commit details
    Browse the repository at this point in the history

  2. Pass [] instead of null to apply for IE<=8's sake. 

    Tests now have the same failure mode in IE<=8 as they do in IE10 and IE9, i.e. they break on test 17 and do not continue.
    @domenic
    domenic committed Jul 27, 2012
    Copy the full SHA
    f99c5fe View commit details
    Browse the repository at this point in the history

  3. Merge pull request #129 from domenic/ie 

    Make work in IE, mostly
    @pksunkara
    pksunkara committed Jul 27, 2012
    Copy the full SHA
    8d40862 View commit details
    Browse the repository at this point in the history