Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-3902 #427

Closed
wants to merge 2 commits into from
Closed

TRUNK-3902 #427

wants to merge 2 commits into from

Conversation

k-joseph
Copy link
Member

fix for [https://tickets.openmrs.org/browse/TRUNK-3902] Proposal: rename concept_numeric.precise property to concept_numeric.allowDecimal

@djazayeri
Copy link
Member

Don't you need a change in the hbm.xml file (and in ConceptNumeric.java)? I don't think the code will work as submitted.

A unit test would be nice. :-)

@dkayiwa
Copy link
Member

dkayiwa commented Oct 28, 2013

For the pull request comment, can you include more than just the ticket number? That is to make the bold heading here clearer: https://github.com/openmrs/openmrs-core/pulls

@k-joseph
Copy link
Member Author

i will always be considering this when making a pull request @dkayiwa , thanks for the tip

@k-joseph
Copy link
Member Author

thanks @djazayeri for your comment, i very much appreciate it, and so i think if the change we want to add in ConceptNumeric.java is renaming precise, then i need to trace for all in our code where it is called and change the method invocation statement since i will have re-factored the getter and setter for it, is it so?

otherwise for the case of the unit test, am very soon beginning to work on it and will by today submit it if all goes well, waiting upon your repply. but i strongly agree with renaming precise in all where it is used to refer to this property

@dkayiwa
Copy link
Member

dkayiwa commented Jan 23, 2014

Closing because author abandoned it.

@dkayiwa dkayiwa closed this Jan 23, 2014
@k-joseph k-joseph deleted the TRUNK-3902 branch February 12, 2014 06:05
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
…edDB is not working properly (openmrs#427)

* Prevent IndexedDB errors in browsers with lacking API capabilities in the sync queue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants