HTTP Pid Minter #353
Closed
HTTP Pid Minter #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Setup authentication in httpclient. | ||
| **/ | ||
| private HttpClient buildClient() { | ||
| HttpClientBuilder builder = HttpClientBuilder.create().useSystemProperties(); |
There was a problem hiding this comment.
Does this pool HTTP clients effectively (for high-rate ingest)?
There was a problem hiding this comment.
I'm not sure what it does by default. I can add a call to use PoolingHttpClientConnectionManager to be sure it'll pool connections.
… wildcard include, breaking out minter config and making it configurable with system property fcrepo.minter.config
| xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd"> | ||
|
|
||
| <!-- Mints PIDs--> | ||
| <bean class="org.fcrepo.kernel.identifiers.UUIDPathMinter" |
There was a problem hiding this comment.
For ease of use, it may be good to have the configuration for the HttpPidMinter also in this file, but commented out.
…tifier from XML responses using XPath
… wildcard include, breaking out minter config and making it configurable with system property fcrepo.minter.config
|
Resolved with: 4959897 Addresses: https://www.pivotaltracker.com/story/show/70678050 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding PID minter implementation that retrieves a PID from a remote REST API service.
Fixes https://www.pivotaltracker.com/story/show/70678050