Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some tests that didn't mock requests enough #322

Merged
merged 1 commit into from Apr 1, 2014
Merged

Conversation

pjz
Copy link
Contributor

@pjz pjz commented Apr 1, 2014

Real requests always have content-length, which
these didn't, so the previous fix where we switch to
always reading a length based on the specified content-length
broke them.

Real requests always have content-length, which
these didn't, so the previous fix where we switch to
always reading a length based on the specified content-length
broke them.
@chadwhitacre
Copy link
Contributor

lgtm

pjz added a commit that referenced this pull request Apr 1, 2014
Fix some tests that didn't mock requests enough
@pjz pjz merged commit 6252330 into master Apr 1, 2014
@chadwhitacre chadwhitacre deleted the fix_sockettests branch October 3, 2014 18:51
Changaco pushed a commit that referenced this pull request Mar 11, 2016
Fix some tests that didn't mock requests enough
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants