Workaround JVM suprocess api limitations

elia · elia · commit 4f4688489641 · 2014-09-18T01:15:13.000+02:00
(see comment in code)
diff --git a/lib/opal/cli_runners/nodejs.rb b/lib/opal/cli_runners/nodejs.rb
@@ -32,8 +32,20 @@ def system_with_output(env, *cmd)
         io_output = IO.try_convert(output)
         return system(env,*cmd) if io_output
 
-        require 'open3'
-        captured_output, status = Open3.capture2(env,*cmd)
+        if RUBY_PLATFORM == 'java'
+          # JRuby has issues in dealing with subprocesses (at least up to 1.7.15)
+          # @headius told me it's mostly fixed on master, but while we wait for it
+          # to ship here's a tempfile workaround.
+          require 'tempfile'
+          require 'shellwords'
+          tempfile = Tempfile.new('opal-node-output')
+          system(env,cmd.shelljoin+" > #{tempfile.path}")
+          captured_output = File.read tempfile.path
+          tempfile.close
+        else
+          require 'open3'
+          captured_output, status = Open3.capture2(env,*cmd)
+        end
         output.write captured_output
       end
 
