Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/misoc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9f02ced39e89
Choose a base ref
...
head repository: m-labs/misoc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 48aae9bee507
Choose a head ref
  • 5 commits
  • 7 files changed
  • 1 contributor

Commits on Mar 17, 2013

  1. dvisampler: fixes

    Sebastien Bourdeauducq committed Mar 17, 2013
    Copy the full SHA
    3a0cf27 View commit details
  2. dvisampler/datacapture: fix tap counter reg

    Sebastien Bourdeauducq committed Mar 17, 2013
    Copy the full SHA
    621526f View commit details
  3. dvisampler/datacapture: connect IODELAY IOCLK0

    Sebastien Bourdeauducq committed Mar 17, 2013
    Copy the full SHA
    74cc045 View commit details
  4. m1crg: set CLKIN_PERIOD for vga_clock_gen

    Sebastien Bourdeauducq committed Mar 17, 2013
    Copy the full SHA
    0c0140a View commit details

Commits on Mar 18, 2013

  1. Use Instance.Input(..., ClockSignal/ResetSignal) instead of Instance.…

    …ClockPort/ResetPort
    Sebastien Bourdeauducq committed Mar 18, 2013
    Copy the full SHA
    48aae9b View commit details
20 changes: 10 additions & 10 deletions milkymist/dvisampler/clocking.py
Original file line number Diff line number Diff line change
@@ -13,9 +13,9 @@ def __init__(self):

self.locked = Signal()
self.serdesstrobe = Signal()
self._cd_pix = ClockDomain()
self._cd_pix5x = ClockDomain()
self._cd_pix20x = ClockDomain()
self.clock_domains._cd_pix = ClockDomain()
self.clock_domains._cd_pix5x = ClockDomain()
self.clock_domains._cd_pix20x = ClockDomain()

###

@@ -27,9 +27,9 @@ def __init__(self):
self.specials += Instance("PLL_BASE",
Instance.Parameter("CLKIN_PERIOD", 22.0),
Instance.Parameter("CLKFBOUT_MULT", 20),
Instance.Parameter("CLKOUT0_DIVIDE", 20), # pix
Instance.Parameter("CLKOUT0_DIVIDE", 1), # pix20x
Instance.Parameter("CLKOUT1_DIVIDE", 4), # pix5x
Instance.Parameter("CLKOUT2_DIVIDE", 1), # pix20x
Instance.Parameter("CLKOUT2_DIVIDE", 20), # pix
Instance.Parameter("COMPENSATION", "INTERNAL"),

Instance.Output("CLKFBOUT", clkfbout),
@@ -42,14 +42,10 @@ def __init__(self):
Instance.Input("RST", self._r_pll_reset.field.r)
)

self.specials += Instance("BUFG",
Instance.Input("I", pll_clk0), Instance.Output("O", self._cd_pix.clk))
self.specials += Instance("BUFG",
Instance.Input("I", pll_clk1), Instance.Output("O", self._cd_pix5x.clk))
locked_async = Signal()
self.specials += Instance("BUFPLL",
Instance.Parameter("DIVIDE", 4),
Instance.Input("PLLIN", pll_clk2),
Instance.Input("PLLIN", pll_clk0),
Instance.ClockPort("GCLK", "pix5x"),
Instance.Input("LOCKED", pll_locked),
Instance.Output("IOCLK", self._cd_pix20x.clk),
@@ -58,3 +54,7 @@ def __init__(self):
)
self.specials += MultiReg(locked_async, self.locked, "sys")
self.comb += self._r_locked.field.w.eq(self.locked)
self.specials += Instance("BUFG",
Instance.Input("I", pll_clk1), Instance.Output("O", self._cd_pix5x.clk))
self.specials += Instance("BUFG",
Instance.Input("I", pll_clk2), Instance.Output("O", self._cd_pix.clk))
8 changes: 5 additions & 3 deletions milkymist/dvisampler/datacapture.py
Original file line number Diff line number Diff line change
@@ -24,16 +24,18 @@ def __init__(self, ntbits, debug=False):
delay_ce = Signal()
delay_rst = Signal()
delay_init = Signal()
self.specials += Instance("IDELAY2",
self.specials += Instance("IODELAY2",
Instance.Parameter("DELAY_SRC", "IDATAIN"),
Instance.Parameter("IDELAY_TYPE", "VARIABLE_FROM_ZERO"),
Instance.Parameter("COUNTER_WRAP_AROUND", "STAY_AT_LIMIT"),
Instance.Parameter("COUNTER_WRAPAROUND", "STAY_AT_LIMIT"),
Instance.Parameter("DATA_RATE", "SDR"),
Instance.Input("IDATAIN", self.pad),
Instance.Output("DATAOUT", pad_delayed),
Instance.Input("INC", delay_inc | delay_init),
Instance.Input("CE", delay_ce | delay_init),
Instance.Input("RST", delay_rst),
Instance.ClockPort("CLK"),
Instance.ClockPort("IOCLK0", "pix20x"),
Instance.Input("CAL", 0),
Instance.Input("T", 1)
)
@@ -119,7 +121,7 @@ def __init__(self, ntbits, debug=False):
if debug:
self.comb += delay_rst.eq(self.delay_rst | self._r_delay_rst.re)
current_tap = self._r_current_tap.field.w
If(delay_rst,
self.sync += If(delay_rst,
current_tap.eq(0)
).Elif(delay_ce,
If(delay_inc,
4 changes: 2 additions & 2 deletions milkymist/framebuffer/__init__.py
Original file line number Diff line number Diff line change
@@ -134,12 +134,12 @@ def __init__(self):
Instance.Output("data_out", fifo_data_out),
Instance.Output("empty"),
Instance.Input("read_en", 1),
Instance.ClockPort("clk_read", "vga"),
Instance.Input("clk_read", ClockSignal("vga")),

Instance.Input("data_in", fifo_data_in),
Instance.Output("full", fifo_full),
Instance.Input("write_en", fifo_write_en),
Instance.ClockPort("clk_write"),
Instance.Input("clk_write", ClockSignal()),

Instance.Input("rst", 0))
t = self.token("dac")
4 changes: 2 additions & 2 deletions milkymist/lm32/__init__.py
Original file line number Diff line number Diff line change
@@ -15,8 +15,8 @@ def __init__(self):
i_adr_o = Signal(32)
d_adr_o = Signal(32)
self.specials += Instance("lm32_top",
Instance.ClockPort("clk_i"),
Instance.ResetPort("rst_i"),
Instance.Input("clk_i", ClockSignal()),
Instance.Input("rst_i", ResetSignal()),

Instance.Input("interrupt", self.interrupt),
#Instance.Input("ext_break", self.ext_break),
8 changes: 4 additions & 4 deletions milkymist/minimac3/__init__.py
Original file line number Diff line number Diff line change
@@ -61,8 +61,8 @@ def __init__(self):
rx_pending_1_r.eq(rx_pending_1)
]
self.specials += Instance("minimac3",
Instance.ClockPort("sys_clk"),
Instance.ResetPort("sys_rst"),
Instance.Input("sys_clk", ClockSignal()),
Instance.Input("sys_rst", ResetSignal()),

Instance.Output("rx_done_0", self.ev.rx0.trigger),
Instance.Output("rx_count_0", self._rx_count_0.field.w),
@@ -84,11 +84,11 @@ def __init__(self):
Instance.Output("wb_dat_o", self.membus.dat_r),
Instance.Output("wb_ack_o", self.membus.ack),

Instance.ClockPort("phy_tx_clk", "eth_tx"),
Instance.Input("phy_tx_clk", ClockSignal("eth_tx")),
Instance.Output("phy_tx_data", self.phy_tx_data),
Instance.Output("phy_tx_en", self.phy_tx_en),
Instance.Output("phy_tx_er", self.phy_tx_er),
Instance.ClockPort("phy_rx_clk", "eth_rx"),
Instance.Input("phy_rx_clk", ClockSignal("eth_rx")),
Instance.Input("phy_rx_data", self.phy_rx_data),
Instance.Input("phy_dv", self.phy_dv),
Instance.Input("phy_rx_er", self.phy_rx_er),
8 changes: 4 additions & 4 deletions milkymist/s6ddrphy/__init__.py
Original file line number Diff line number Diff line change
@@ -9,10 +9,10 @@ def __init__(self, a, ba, d):
Instance.Parameter("NUM_AD", a),
Instance.Parameter("NUM_BA", ba),
Instance.Parameter("NUM_D", d),
Instance.ClockPort("sys_clk"),
Instance.ClockPort("clk2x_270", "sys2x_270"),
Instance.ClockPort("clk4x_wr", "sys4x_wr"),
Instance.ClockPort("clk4x_rd", "sys4x_rd")
Instance.Input("sys_clk", ClockSignal()),
Instance.Input("clk2x_270", ClockSignal("sys2x_270")),
Instance.Input("clk4x_wr", ClockSignal("sys4x_wr")),
Instance.Input("clk4x_rd", ClockSignal("sys4x_rd"))
]
for name, width, cl in [
("clk4x_wr_strb", 1, Instance.Input),
2 changes: 1 addition & 1 deletion verilog/m1crg/m1crg.v
Original file line number Diff line number Diff line change
@@ -263,7 +263,7 @@ DCM_CLKGEN #(
.CLKFX_DIVIDE(4),
.CLKFX_MD_MAX(2.0),
.CLKFX_MULTIPLY(2),
.CLKIN_PERIOD(0.0),
.CLKIN_PERIOD(20.0),
.SPREAD_SPECTRUM("NONE"),
.STARTUP_WAIT("FALSE")
) vga_clock_gen (