Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaSupport refactoring API (byte-code) incompatibility with extensions #2585

Closed
kares opened this issue Feb 11, 2015 · 3 comments
Closed

JavaSupport refactoring API (byte-code) incompatibility with extensions #2585

kares opened this issue Feb 11, 2015 · 3 comments
Milestone
JRuby 9.0.0.0.pre2

Comments

@kares
Copy link
Member

kares commented Feb 11, 2015

on 9K (recently - not in preview1) JavaSupport was changed from class to interface, such change for extension APIs is hard to support without re-compiling ... esp. hard to target 1.7 and 9K at the same time.

sample failure seen on travis-ci :

 Java::JavaLang::IncompatibleClassChangeError: Found interface org.jruby.javasupport.JavaSupport, but class was expected
arjdbc.jdbc.DriverWrapper.loadDriver(DriverWrapper.java:77)
arjdbc.jdbc.DriverWrapper.<init>(DriverWrapper.java:49)
arjdbc.jdbc.RubyJdbcConnection.newDriverWrapper(RubyJdbcConnection.java:1709)
arjdbc.jdbc.RubyJdbcConnection.setDriverFactory(RubyJdbcConnection.java:1702)
arjdbc.jdbc.RubyJdbcConnection.setupConnectionFactory(RubyJdbcConnection.java:1813)
arjdbc.jdbc.RubyJdbcConnection.doInitialize(RubyJdbcConnection.java:512)
arjdbc.jdbc.RubyJdbcConnection.initialize(RubyJdbcConnection.java:504)

... coming from a simple: runtime.getJavaSupport().loadJavaClassVerbose(name);

such call is likely also in JRuby-OpenSSL that I know of (besides AR-JDBC), not sure for other extensions out there ... just wanted to let you guys know - as far as I see it's mostly due mocking/truffle
@chrisseaton
Copy link
Contributor

Yes this is to support AOT compilation of JRuby. I can do it with an abstract class as well though.

@kares
Copy link
Member Author

kares commented Feb 26, 2015

@chrisseaton that would be a win-win ... thanks!

@kares
Copy link
Member Author

kares commented Mar 2, 2015

compatibility restored at bf8a55a ... thanks!

@kares kares closed this as completed Mar 2, 2015
@enebo enebo added this to the 9.0.0.0.pre2 milestone Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.0.0.0.pre2
Development

No branches or pull requests
3 participants
@enebo @kares @chrisseaton