dgram-uv: black hole incoming messages after closing

Fixes test/simple/test-dgram-pingpong.js on windows
nodejs · Sep 5, 2011 · b5d58f1 · b5d58f1
1 parent 01bf209
commit b5d58f1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/dgram_uv.js b/lib/dgram_uv.js
@@ -285,7 +285,11 @@ Socket.prototype._stopReceiving = function() {
   if (!this._receiving)
     return;
 
-  this._handle.onmessage = null;
+  // Black hole messages coming in when reading is stopped. Libuv might do
+  // this, but node applications (e.g. test/simple/test-dgram-pingpong) may
+  // not expect it.
+  this._handle.onmessage = noop;
+
   this._handle.recvStop();
   this._receiving = false;
   this.fd = null; // compatibility hack