Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed arity issue with RubyMethod #2584

Merged
merged 1 commit into from Feb 10, 2015
Merged

Fixed arity issue with RubyMethod #2584

merged 1 commit into from Feb 10, 2015

Conversation

Who828
Copy link
Contributor

@Who828 Who828 commented Feb 10, 2015

Fixes #2480 and #2512 with RubyMethod by taking account of required kwargs.

@enebo enebo added this to the 9.0.0.0.pre2 milestone Feb 10, 2015
enebo added a commit that referenced this pull request Feb 10, 2015
@enebo
Merge pull request #2584 from Who828/fix_2480
42c5b25 
Fixed arity issue with RubyMethod
@enebo enebo merged commit 42c5b25 into jruby:master Feb 10, 2015
@enebo enebo mentioned this pull request Feb 11, 2015
Merged
@enebo
Copy link
Member

enebo commented Feb 11, 2015

@Who828 Looks like some rubyspecs failed from this fix...

@Who828
Copy link
Contributor Author

Who828 commented Feb 11, 2015

Darn, I missed in midst of OpenSSL NameError.
I have fixed it now, will open a new PR.

@Who828 Who828 mentioned this pull request Feb 11, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core JRuby 9000 ruby 2.0-2.2
Projects
None yet
Milestone
JRuby 9.0.0.0.pre2
Development

Successfully merging this pull request may close these issues.

Keyword arguments arity issue
2 participants
@Who828 @enebo