Address Reduce Sonar major issue - "Use Index Of Char"

- Use String.indexOf(char) when checking for the index of a single character; it executes faster. Resolves: https://jira.duraspace.org/browse/FCREPO-1328
fcrepo · Feb 17, 2015 · 4f3dee0 · 4f3dee0
1 parent d9a596b
commit 4f3dee0
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/fcrepo-kernel-impl/src/main/java/org/fcrepo/kernel/impl/identifiers/HashConverter.java b/fcrepo-kernel-impl/src/main/java/org/fcrepo/kernel/impl/identifiers/HashConverter.java
@@ -25,7 +25,7 @@ public class HashConverter extends InternalIdentifierConverter {
 
     @Override
     protected String doForward(final String externalId) {
-        final int i = externalId.indexOf("#");
+        final int i = externalId.indexOf('#');
         if (i >= 0) {
             return externalId.substring(0, i) + "/#/" + externalId.substring(i + 1).replace("/", "%2F");
         }

diff --git a/...pl/src/main/java/org/fcrepo/kernel/impl/observer/eventmappings/AllNodeEventsOneEvent.java b/...pl/src/main/java/org/fcrepo/kernel/impl/observer/eventmappings/AllNodeEventsOneEvent.java
@@ -124,7 +124,7 @@ private void addProperty( final FedoraEvent fedoraEvent, final Event ev ) {
             try {
                 if (PROPERTY_EVENT_TYPES.contains(ev.getType())) {
                     final String eventPath = ev.getPath();
-                    fedoraEvent.addProperty(eventPath.substring(eventPath.lastIndexOf("/") + 1));
+                    fedoraEvent.addProperty(eventPath.substring(eventPath.lastIndexOf('/') + 1));
                 } else {
                     log.trace("Not adding non-event property: {}, {}", fedoraEvent, ev);
                 }

diff --git a/...-kernel-impl/src/main/java/org/fcrepo/kernel/impl/rdf/impl/mappings/PropertyToTriple.java b/...-kernel-impl/src/main/java/org/fcrepo/kernel/impl/rdf/impl/mappings/PropertyToTriple.java
@@ -126,7 +126,7 @@ private com.hp.hpl.jena.graph.Node convertObject(final Property p, final Value v
 
         if (object.isLiteral()) {
             final String propertyName = p.getName();
-            final int i = propertyName.indexOf("@");
+            final int i = propertyName.indexOf('@');
 
             if (i > 0) {
                 final LiteralLabel literal = object.getLiteral();

diff --git a/fcrepo-kernel/src/main/java/org/fcrepo/kernel/utils/NamespaceTools.java b/fcrepo-kernel/src/main/java/org/fcrepo/kernel/utils/NamespaceTools.java
@@ -91,8 +91,8 @@ public static void validatePath(final Session session, final String path) {
         final String[] pathSegments = relPath.split("/");
         for (final String segment : pathSegments) {
             if (segment.length() > 0 && segment.contains(":") &&
-                    !segment.substring(0, segment.indexOf(":")).equals("fedora")) {
-                final String prefix = segment.substring(0, segment.indexOf(":"));
+                    !segment.substring(0, segment.indexOf(':')).equals("fedora")) {
+                final String prefix = segment.substring(0, segment.indexOf(':'));
                 if (prefix.length() == 0) {
                     throw new FedoraInvalidNamespaceException(
                             String.format("Unable to identify namespace for (%s)", segment));