Fix error handling in ldap_get_field_from_username

dregad · dregad · commit 79afb164ce7e · 2011-09-20T12:12:10.000+02:00
When successful, ldap_get_entries always returns an array with at least
one element inside (the count), so the check for no matches was always
successful even when no values were retrieved from LDAP.

Fixes #13331
diff --git a/core/ldap_api.php b/core/ldap_api.php
@@ -252,7 +252,7 @@ function ldap_get_field_from_username( $p_username, $p_field ) {
 	ldap_unbind( $t_ds );
 
 	# If no matches, return null.
-	if ( count( $t_info ) == 0 ) {
+	if ( $t_info['count'] == 0 ) {
 		log_event( LOG_LDAP, "No matches found." );
 		return null;
 	}

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ function ldap_get_field_from_username( $p_username, $p_field ) {`
`252`	`252`	`ldap_unbind( $t_ds );`
`253`	`253`
`254`	`254`	`# If no matches, return null.`
`255`		`- if ( count( $t_info ) == 0 ) {`
	`255`	`+ if ( $t_info['count'] == 0 ) {`
`256`	`256`	`log_event( LOG_LDAP, "No matches found." );`
`257`	`257`	`return null;`
`258`	`258`	`}`