Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonar warnings #722

Closed
wants to merge 2 commits into from
Closed

Fix sonar warnings #722

wants to merge 2 commits into from

Conversation

osmandin
Copy link
Contributor

@@ -449,4 +449,9 @@ private String txSegment() {
return EMPTY;
}
}

@Override
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supporting hashCode() seems like an a sign of a more fundamental issue.
But any ways, the related Sonar issue seems to be gone: http://sonar.fcrepo.org/drilldown/issues/1?&rule=findbugs%3AEQ_COMPARETO_USE_OBJECT_EQUALS&rule_sev=MAJOR&severity=MAJOR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaning, leave out hashcode?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not clear to me that overriding hashCode() is something we want to do.
Additionally, I am not seeing an indication in Sonar that would suggest we override hashCode().

@awoods
Copy link

awoods commented Feb 19, 2015

Resolved with: 58874be

@awoods awoods closed this Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants