It is a non-functional change #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in order to process FCREPO-1290
| @@ -56,19 +55,19 @@ | |||
| */ | |||
|
|
|||
| public PropertiesRdfContext(final FedoraResource resource, | |||
| final IdentifierConverter<Resource, FedoraResource> idTranslator) | |||
| throws RepositoryException { | |||
| final IdentifierConverter<Resource, FedoraResource> idTranslator) | |||
There was a problem hiding this comment.
The previous formatting, with the arguments aligned, reads better, as far as I am concerned.
There was a problem hiding this comment.
Why not put final IdentifierConverter<Resource, FedoraResource> idTranslator on the line of the method declaration? This looks better than before, but still not ideal.
There was a problem hiding this comment.
Because it reads badly and after this change it reads better.
There was a problem hiding this comment.
@ajs6f, are you suggesting that the updated (unaligned) formatting reads better than the unmodified (aligned) version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just fix the import order and the indent in order to start FCREPO-1290.