Reduce Sonar major issues - "Static Variable Name" and "Avoid commented-... #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed-out lines of code" - change static variable name match pattern '^[a-z][a-zA-Z0-9]*$' - remove commented-out lines of code Resolves: https://jira.duraspace.org/browse/FCREPO-1332
| @@ -138,7 +138,7 @@ | |||
|
|
|||
| protected FedoraResource resource; | |||
|
|
|||
| private static long MAX_BUFFER_SIZE = 10240000; | |||
| private static long max_BUFFER_SIZE = 10240000; | |||
There was a problem hiding this comment.
I suspect this issue could also be resolved by making MAX_BUFFER_SIZE final.
- restore comment codes - Please check my JIRA comments. Thanks
|
Resolved with: 9ab07de |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...out lines of code"
Resolves: https://jira.duraspace.org/browse/FCREPO-1332