Fix bug in flat_map for enumerables that yield multiple values #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sferik - the specs get synced between here and rubyspec bidirectionally, so just adding the spec here is okay (and preferred, if the bug fix is being committed here as well). However, the |
|
@jemc My mistake. I will review the |
sferik
force-pushed
the
flat_map_multi_yield
branch
from
f74968f
to
9b6ba14
Compare
sferik
force-pushed
the
flat_map_multi_yield
branch
from
fac04b5
to
aa2bc8b
Compare
|
I believe the failed job is from something else. Re-running (log here) but this looks OK to me. |
sferik
force-pushed
the
flat_map_multi_yield
branch
from
aa2bc8b
to
1a40288
Compare
jc00ke
added a commit
that referenced
this pull request
Dec 22, 2014
Fix bug in flat_map for enumerables that yield multiple values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s a small bug in the implementation of
Enumerable#flat_mapwith enumerables that yield multiple values. The added spec fails before this patch is applied, returning[1, 2]instead of[1]. I believe this spec should also be added to the RubySpec project. Should I submit a separate pull request for that or will it be added to RubySpec automatically?