Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0b67c3497de6
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6b2cc1bd52d4
Choose a head ref
  • 2 commits
  • 21 files changed
  • 1 contributor

Commits on Feb 14, 2015

  1. [Truffle] Only exclude specs failing on Windows when running on Windows. 

    * Similar approach to JRuby and MSpec's own tests with (ci_)xtags.
    @eregon
    eregon committed Feb 14, 2015
    1
    Copy the full SHA
    978bc56 View commit details

  2. [Truffle] Two failing specs are actually global failures.

    @eregon
    eregon committed Feb 14, 2015
    Copy the full SHA
    6b2cc1b View commit details
2 changes: 1 addition & 1 deletion spec/truffle/tags/core/class/inherited_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
fails:Class.inherited is invoked with the child Class when self is subclassed
fails(windows bug):Class.inherited is invoked only once per subclass
windows:Class.inherited is invoked only once per subclass
6 changes: 3 additions & 3 deletions spec/truffle/tags/core/encoding/default_internal_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
fails(windows bug):Encoding.default_internal with command line options returns Encoding::UTF_8 if ruby was invoked with -U
fails(windows bug):Encoding.default_internal with command line options uses the encoding specified when ruby is invoked with an '-E :internal' argument
fails(windows bug):Encoding.default_internal with command line options uses the encoding specified when ruby is invoked with an '-E external:internal' argument
windows:Encoding.default_internal with command line options returns Encoding::UTF_8 if ruby was invoked with -U
windows:Encoding.default_internal with command line options uses the encoding specified when ruby is invoked with an '-E :internal' argument
windows:Encoding.default_internal with command line options uses the encoding specified when ruby is invoked with an '-E external:internal' argument
2 changes: 1 addition & 1 deletion spec/truffle/tags/core/encoding/dummy_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
fails(inherited):Encoding#dummy? returns true for dummy encodings
fails(windows bug):Encoding#dummy? returns true for dummy encodings
windows:Encoding#dummy? returns true for dummy encodings
4 changes: 2 additions & 2 deletions spec/truffle/tags/core/file/dirname_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -6,5 +6,5 @@ fails(windows):File.dirname returns all the components of filename except the la
fails(windows):File.dirname returns the return all the components of filename except the last one (Windows format)
fails(windows):File.dirname returns the return all the components of filename except the last one (windows unc)
fails(windows):File.dirname returns the return all the components of filename except the last one (forward_slash)
fails(windows bug):File.dirname ignores a trailing /
fails(windows bug):File.dirname returns the return all the components of filename except the last one (unix format)
windows:File.dirname ignores a trailing /
windows:File.dirname returns the return all the components of filename except the last one (unix format)
10 changes: 5 additions & 5 deletions spec/truffle/tags/core/file/expand_path_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -16,8 +16,8 @@ fails:File.expand_path when HOME is not set raises an ArgumentError when passed
fails:File.expand_path when HOME is not set raises an ArgumentError when passed '~' if HOME == ''
fails(windows):File.expand_path does not return a frozen string
fails(windows):File.expand_path expands C:/./dir to C:/dir
fails(windows bug):File.expand_path converts a pathname to an absolute pathname, Ruby-Talk:18512
fails(windows bug):File.expand_path converts a pathname to an absolute pathname, using a complete path
fails(windows bug):File.expand_path raises a TypeError if not passed a String type
fails(windows bug):File.expand_path does not modify the string argument
fails(windows bug):File.expand_path returns a String when passed a String subclass
windows:File.expand_path converts a pathname to an absolute pathname, Ruby-Talk:18512
windows:File.expand_path converts a pathname to an absolute pathname, using a complete path
windows:File.expand_path raises a TypeError if not passed a String type
windows:File.expand_path does not modify the string argument
windows:File.expand_path returns a String when passed a String subclass
6 changes: 3 additions & 3 deletions spec/truffle/tags/core/file/file_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
fails:File includes File::Constants
fails:File.file? accepts an object that has a #to_path method
fails(windows bug):File.file? returns true if the named file exists and is a regular file.
fails(windows bug):File.file? raises an ArgumentError if not passed one argument
fails(windows bug):File.file? raises a TypeError if not passed a String type
windows:File.file? returns true if the named file exists and is a regular file.
windows:File.file? raises an ArgumentError if not passed one argument
windows:File.file? raises a TypeError if not passed a String type
2 changes: 1 addition & 1 deletion spec/truffle/tags/core/file/path_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
fails:File#path returns the pathname used to create file as a string
fails(windows bug):File.path returns the full path for the given file
windows:File.path returns the full path for the given file
4 changes: 2 additions & 2 deletions spec/truffle/tags/core/file/readable_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
fails:File.readable? accepts an object that has a #to_path method
fails(windows bug):File.readable? returns true if named file is readable by the effective user id of the process, otherwise false
fails(windows bug):File.readable? returns false if the file does not exist
windows:File.readable? returns true if named file is readable by the effective user id of the process, otherwise false
windows:File.readable? returns false if the file does not exist
6 changes: 3 additions & 3 deletions spec/truffle/tags/core/file/size_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -17,6 +17,6 @@ fails:File#size returns the file's current size even if modified
fails:File#size raises an IOError on a closed file
fails:File#size follows symlinks if necessary
fails:File#size for an empty file returns 0
fails(windows bug):File.size? returns the size of the file if it exists and is not empty
fails(windows bug):File.size? returns nil if file_name doesn't exist or has 0 size
fails(windows bug):File.size? returns nil if file_name is empty
windows:File.size? returns the size of the file if it exists and is not empty
windows:File.size? returns nil if file_name doesn't exist or has 0 size
windows:File.size? returns nil if file_name is empty
2 changes: 1 addition & 1 deletion spec/truffle/tags/core/file/stat/file_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -2,4 +2,4 @@ fails:File::Stat#file? returns true if the named file exists and is a regular fi
fails:File::Stat#file? accepts an object that has a #to_path method
fails:File::Stat#file? returns true if the null device exists and is a regular file.
fails:File::Stat#file? raises a TypeError if not passed a String type
fails(windows bug):File::Stat#file? raises an ArgumentError if not passed one argument
windows:File::Stat#file? raises an ArgumentError if not passed one argument
4 changes: 2 additions & 2 deletions spec/truffle/tags/core/io/readlines_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -45,5 +45,5 @@ fails:IO.readlines when passed name, separator, limit, options calls #to_hash to
fails:IO.readlines encodes lines using the default external encoding
fails:IO.readlines encodes lines using the default internal encoding, when set
fails:IO.readlines ignores the default internal encoding if the external encoding is ASCII-8BIT
fails(windows bug):IO.readlines does not change $_
fails(windows bug):IO.readlines raises TypeError if the first parameter is nil
windows:IO.readlines does not change $_
windows:IO.readlines raises TypeError if the first parameter is nil
4 changes: 2 additions & 2 deletions spec/truffle/tags/core/kernel/eval_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -7,5 +7,5 @@ fails:Kernel#eval returns from the scope calling #eval when evaluating 'return'
fails:Kernel#eval unwinds through a Proc-style closure and returns from a lambda-style closure in the closure chain
slow:Kernel#eval raises a LocalJumpError if there is no lambda-style closure in the chain
slow:Kernel#eval does not share locals across eval scopes
fails(windows bug):Kernel#eval does not share locals across eval scopes
fails(windows bug):Kernel#eval raises a LocalJumpError if there is no lambda-style closure in the chain
windows:Kernel#eval does not share locals across eval scopes
windows:Kernel#eval raises a LocalJumpError if there is no lambda-style closure in the chain
4 changes: 2 additions & 2 deletions spec/truffle/tags/core/kernel/load_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -24,6 +24,6 @@ fails:Kernel.load (path resolution) with an unreadable file raises a LoadError
fails:Kernel.load loads file even after $LOAD_PATH change
fails:Kernel.load sets the enclosing scope to an anonymous module if passed true for 'wrap'
fails:Kernel.load (shell expansion) expands a tilde to the HOME environment variable as the path to load
fails(windows bug):Kernel#load loads a file that recursively requires itself
fails(windows bug):Kernel.load loads a file that recursively requires itself
windows:Kernel#load loads a file that recursively requires itself
windows:Kernel.load loads a file that recursively requires itself

2 changes: 1 addition & 1 deletion spec/truffle/tags/core/method/source_location_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
fails:Method#source_location works for methods defined with an UnboundMethod
fails:Method#source_location for a Method generated by respond_to_missing? returns nil
fails(windows bug):Method#source_location sets the first value to the path of the file in which the method was defined
windows:Method#source_location sets the first value to the path of the file in which the method was defined
32 changes: 16 additions & 16 deletions spec/truffle/tags/core/signal/trap_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
fails:Signal.trap the special EXIT signal code accepts the EXIT code
fails:Signal.trap the special EXIT signal code runs the proc before at_exit handlers
fails(windows bug):Signal.trap returns the previous handler
fails(windows bug):Signal.trap accepts a block in place of a proc/command argument
fails(windows bug):Signal.trap ignores the signal when passed nil
fails(windows bug):Signal.trap accepts 'DEFAULT' as a symbol in place of a proc
fails(windows bug):Signal.trap accepts 'SIG_DFL' as a symbol in place of a proc
fails(windows bug):Signal.trap accepts 'SIG_IGN' as a symbol in place of a proc
fails(windows bug):Signal.trap accepts 'IGNORE' as a symbol in place of a proc
fails(windows bug):Signal.trap accepts long names as Strings
fails(windows bug):Signal.trap acceps short names as Strings
fails(windows bug):Signal.trap accepts long names as Symbols
fails(windows bug):Signal.trap accepts short names as Symbols
fails(windows bug):Signal.trap accepts 'SIG_DFL' in place of a proc
fails(windows bug):Signal.trap accepts 'DEFAULT' in place of a proc
fails(windows bug):Signal.trap accepts 'SIG_IGN' in place of a proc
fails(windows bug):Signal.trap accepts 'IGNORE' in place of a proc
fails(windows bug):Signal.trap the special EXIT signal code can unset the handler
windows:Signal.trap returns the previous handler
windows:Signal.trap accepts a block in place of a proc/command argument
windows:Signal.trap ignores the signal when passed nil
windows:Signal.trap accepts 'DEFAULT' as a symbol in place of a proc
windows:Signal.trap accepts 'SIG_DFL' as a symbol in place of a proc
windows:Signal.trap accepts 'SIG_IGN' as a symbol in place of a proc
windows:Signal.trap accepts 'IGNORE' as a symbol in place of a proc
windows:Signal.trap accepts long names as Strings
windows:Signal.trap acceps short names as Strings
windows:Signal.trap accepts long names as Symbols
windows:Signal.trap accepts short names as Symbols
windows:Signal.trap accepts 'SIG_DFL' in place of a proc
windows:Signal.trap accepts 'DEFAULT' in place of a proc
windows:Signal.trap accepts 'SIG_IGN' in place of a proc
windows:Signal.trap accepts 'IGNORE' in place of a proc
windows:Signal.trap the special EXIT signal code can unset the handler
2 changes: 1 addition & 1 deletion spec/truffle/tags/core/struct/to_s_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
fails(windows bug):Struct#to_s is a synonym for inspect
windows:Struct#to_s is a synonym for inspect
6 changes: 3 additions & 3 deletions spec/truffle/tags/language/break_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -7,6 +7,6 @@ fails:Executing break from within a block returns from the original invoking met
slow:The break statement in a lambda created at the toplevel returns a value when invoking from a method
slow:The break statement in a lambda created at the toplevel returns a value when invoking from a block
slow:The break statement in a lambda created at the toplevel returns a value when invoking from the toplevel
fails(windows bug):The break statement in a lambda created at the toplevel returns a value when invoking from the toplevel
fails(windows bug):The break statement in a lambda created at the toplevel returns a value when invoking from a method
fails(windows bug):The break statement in a lambda created at the toplevel returns a value when invoking from a block
windows:The break statement in a lambda created at the toplevel returns a value when invoking from the toplevel
windows:The break statement in a lambda created at the toplevel returns a value when invoking from a method
windows:The break statement in a lambda created at the toplevel returns a value when invoking from a block
4 changes: 2 additions & 2 deletions spec/truffle/tags/language/file_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
fails(windows bug):The __FILE__ pseudo-variable equals the absolute path of a file loaded by an absolute path
fails(windows bug):The __FILE__ pseudo-variable equals the absolute path of a file loaded by a relative path
windows:The __FILE__ pseudo-variable equals the absolute path of a file loaded by an absolute path
windows:The __FILE__ pseudo-variable equals the absolute path of a file loaded by a relative path
10 changes: 5 additions & 5 deletions spec/truffle/tags/language/predefined/data_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
fails(inherited):The DATA constant succeeds in locking the file DATA came from
fails:The DATA constant does not change when an included files also has a __END__
fails:The DATA constant is included in an otherwise empty file
slow:The DATA constant exists when the main script contains __END__
slow:The DATA constant does not exist when the main script contains no __END__
slow:The DATA constant does not exist when an included file has a __END__
slow:The DATA constant does not change when an included files also has a __END__
slow:The DATA constant is included in an otherwise empty file
fails(windows bug):The DATA constant exists when the main script contains __END__
fails(windows bug):The DATA constant does not exist when the main script contains no __END__
fails(windows bug):The DATA constant does not exist when an included file has a __END__
fails(windows bug):The DATA constant does not change when an included files also has a __END__
fails(windows bug):The DATA constant is included in an otherwise empty file
windows:The DATA constant exists when the main script contains __END__
windows:The DATA constant does not exist when the main script contains no __END__
windows:The DATA constant does not change when an included files also has a __END__
10 changes: 5 additions & 5 deletions spec/truffle/tags/language/predefined_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -4,8 +4,8 @@ slow:The predefined global constant STDERR has the encodings set by #set_encodin
slow:The predefined global constant STDIN retains the encoding set by #set_encoding when Encoding.default_external is changed
slow:The predefined global constant STDIN has the encodings set by #set_encoding
slow:The predefined global constant STDOUT has the encodings set by #set_encoding
fails(windows bug):Execution variable $: does not include '.' when the taint check level > 1
fails(windows bug):The predefined global constant STDIN has the encodings set by #set_encoding
fails(windows bug):The predefined global constant STDIN retains the encoding set by #set_encoding when Encoding.default_external is changed
fails(windows bug):The predefined global constant STDOUT has the encodings set by #set_encoding
fails(windows bug):The predefined global constant STDERR has the encodings set by #set_encoding
windows:Execution variable $: does not include '.' when the taint check level > 1
windows:The predefined global constant STDIN has the encodings set by #set_encoding
windows:The predefined global constant STDIN retains the encoding set by #set_encoding when Encoding.default_external is changed
windows:The predefined global constant STDOUT has the encodings set by #set_encoding
windows:The predefined global constant STDERR has the encodings set by #set_encoding
5 changes: 5 additions & 0 deletions spec/truffle/truffle.mspec
View file
Original file line number Diff line number Diff line change
@@ -119,6 +119,11 @@ core += [
[/_spec.rb$/, '_tags.txt']
]

if windows?
# exclude specs tagged with 'windows'
set :xtags, (get(:xtags) || []) + ['windows']
end

MSpec.enable_feature :encoding
MSpec.enable_feature :fiber
MSpec.disable_feature :fork