Skip to content

Commit ed04e8e

Browse files
nerzhulnerzhul
committedFeb 16, 2015
[Patch 2/4] Network rework: packet writing, sending and cleanups
NetworkPacket.cpp: * Remove some deprecated functions, we must use streaming interface * m_data converted from u8* to std::vector<u8> * Add an exporter to forge packet to Connection object * implement operator << std::wstring. n * implement operator << std::string * dynamic resize when write packet content. * fix string writing and performances. * create ServerCommandFactory, used by client to get useful informations about packet processing (sending). * Reliability * Transmit channel * Implement putRawString for some ugly char (_INIT packet), and use it. * Many packet read and write migrated * Implement oldForgePacket to interface writing with current connection * fix U8/char/bool writing * fix string writing and performances. * add some missing functions * Use v3s16 read instead of reading x,y,z separately * Add irr::video::SColor support into packets * Add some missing handlers * Add a template function to increase offset * Throw a serialization error on packet reading (must be improved) PacketFactories: * Create ServerCommandFactory, used by client to get useful informations about packet processing (sending). * Create ClientCommandFactory, used by server to get useful informations about packet processing (sending). Client.cpp: * implement NetworkPacket ::Send interface. * Move packet handlers to a dedicated file * Remove Client::Send(SharedBuffer) Server.cpp: * implement NetworkPacket ::Send interface. * Rewrite all packets using NetworkPacket * Move packet handlers to a dedicated file * Remove Server::Send(SharedBuffer) ClientIface.cpp: * Remove sendToAll(SharedBuffer<u8>) Connection.hpp rework: * Remove duplicate include * Remove duplicate negation * Remove a useless variable * Improve code performance by using a m_peers_list instead of scanning m_peers map * Remove Connection::Send(SharedBuffer) * Fix useafterfree into NetworkPacket Sending * Remove unused Connection::sendToAll Test.cpp: * Remove dead code * Update tests to use NetworkPackets Misc: * add new wrappers to Send packets in client, using NetworkPacket * Add NetworkPacket methods for Connection * coding style fix * dead code since changes cleanup * Use v3s16 read instead of reading x,y,z separately in some packets * Use different files to handle packets received by client and server * Cleanup: Remove useless includes ok @Zeno- Tested by @Zeno- @VanessaE and @nerzhul on running servers
·
5.11.00.4.13
1 parent efa9775 commit ed04e8e

22 files changed

+3970
-4231
lines changed
 

Diff for: ‎src/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,6 @@ set(common_SRCS
361361
cavegen.cpp
362362
clientiface.cpp
363363
collision.cpp
364-
connection.cpp
365364
content_abm.cpp
366365
content_mapnode.cpp
367366
content_nodemeta.cpp
@@ -429,9 +428,10 @@ set(common_SRCS
429428
version.cpp
430429
voxel.cpp
431430
voxelalgorithms.cpp
431+
network/connection.cpp
432432
network/networkpacket.cpp
433+
network/packethandlers/server.cpp
433434
network/serveropcodes.cpp
434-
network/toserverpacket.cpp
435435
${JTHREAD_SRCS}
436436
${common_SCRIPT_SRCS}
437437
${UTIL_SRCS}
@@ -496,7 +496,7 @@ set(minetest_SRCS
496496
wieldmesh.cpp
497497
client/clientlauncher.cpp
498498
network/clientopcodes.cpp
499-
network/toclientpacket.cpp
499+
network/packethandlers/client.cpp
500500
${minetest_SCRIPT_SRCS}
501501
)
502502
list(SORT minetest_SRCS)

0 commit comments

Comments
 (0)
Please sign in to comment.