New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get pod for modules #9
Conversation
use strict; | ||
use warnings; | ||
use Test::More tests => 5; | ||
use Test::Fatal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any Test::Fatal methods being used here?
hi Renee, we already support pod fetching (by type) through the module object: why was this needed? (i want to understand if there is something we missed) cheers, |
Hi Mickey, with the code you mentioned, an unnecessary request is done. And when you want the pod for the same module twice a second request is done. Renee |
@oalders you were right. I removed "use Test::Fatal" |
according to your code, you will still issue a separate request for the same pod for each type. |
yes, for different types you have to do seperate requests as there is no way to get them in one request. I have a use case where I want the pod but not the other module information. So I'd like to avoid the extra request that is done when I have to write ->module( "modulename" ). |
FWIW, when I'm building Pod for iCPAN, I have a similar use case. I already know everything I need to know about the modules -- I just need the Pod. This seems like an elegant way to solve it. |
To expand on this, when I'm fetching Pod for everything in 02packages, the additional request would add a fair amount of overhead. |
sure, saving on the module fetch is fair enough (i thought the argument was for fetching the pod twice). |
...