Removed requirement for fedoraUser in auth'ed connections #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoods
pushed a commit
that referenced
this pull request
May 15, 2014
…306268 Removed requirement for fedoraUser in auth'ed connections Addresses: https://www.pivotaltracker.com/story/show/70306268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/70306268
Removed the requirement for fedoraUser, but left the hard-coded option there as a default configuration. Now you can configure a Tomcat role in ContainerRolesPrincipalProvider, for instance, and the user with that role doesn't also have to be in the fedoraUser role (or you can have principal configured through an HTTP header from any configured user role, rather than just the fedoraUser one).
But, you do have to configure the any new role you want to use through BASIC auth in the web.xml file:
I was unable to find a way to make it more dynamic (not require that extra configuration -- which is what I was originally hoping for). This might make continuing to use fedoraUser more attractive since it's pre-configured, but now there is an option to use another role if you want to configure it.
If this PR is accepted, a note should be added to https://www.pivotaltracker.com/story/show/70710348, noting this as something else to document.