remove a few useless imports

mojolicious · Feb 11, 2015 · 8180023 · 8180023
1 parent b542059
commit 8180023
Show file tree

Hide file tree

Showing 15 changed files with 18 additions and 18 deletions.
diff --git a/lib/Mojo/Cookie/Response.pm b/lib/Mojo/Cookie/Response.pm
@@ -22,8 +22,8 @@ sub parse {
 
       next unless $ATTRS{my $attr = lc $name};
       $value = Mojo::Date->new($value)->epoch if $attr eq 'expires';
-      $cookies[-1]{$attr eq 'max-age' ? 'max_age' : $attr}
-        = $attr eq 'secure' || $attr eq 'httponly' ? 1 : $value;
+      $value = 1 if $attr eq 'secure' || $attr eq 'httponly';
+      $cookies[-1]{$attr eq 'max-age' ? 'max_age' : $attr} = $value;
     }
   }
 

diff --git a/lib/Mojo/DOM.pm b/lib/Mojo/DOM.pm
@@ -322,7 +322,7 @@ sub _text {
 
     # Text
     my $chunk = '';
-    if ($type eq 'text') { $chunk = $trim ? squish($node->[1]) : $node->[1] }
+    if ($type eq 'text') { $chunk = $trim ? squish $node->[1] : $node->[1] }
 
     # CDATA or raw text
     elsif ($type eq 'cdata' || $type eq 'raw') { $chunk = $node->[1] }

diff --git a/lib/Mojo/DOM/HTML.pm b/lib/Mojo/DOM/HTML.pm
@@ -131,7 +131,7 @@ sub parse {
           # Empty tag
           ++$closing and next if $key eq '/';
 
-          $attrs{$key} = defined $value ? html_unescape($value) : $value;
+          $attrs{$key} = defined $value ? html_unescape $value : $value;
         }
 
         # "image" is an alias for "img"

diff --git a/lib/Mojo/Home.pm b/lib/Mojo/Home.pm
@@ -7,7 +7,7 @@ use File::Basename 'dirname';
 use File::Find 'find';
 use File::Spec::Functions qw(abs2rel catdir catfile splitdir);
 use FindBin;
-use Mojo::Util qw(class_to_path slurp);
+use Mojo::Util 'class_to_path';
 
 has parts => sub { [] };
 

diff --git a/lib/Mojo/Loader.pm b/lib/Mojo/Loader.pm
@@ -69,7 +69,7 @@ sub _all {
   while (@files) {
     my ($name, $data) = splice @files, 0, 2;
     $all->{$name} = $name =~ s/\s*\(\s*base64\s*\)$//
-      && ++$BIN{$class}{$name} ? b64_decode($data) : $data;
+      && ++$BIN{$class}{$name} ? b64_decode $data : $data;
   }
 
   return $all;

diff --git a/lib/Mojo/Message/Request.pm b/lib/Mojo/Message/Request.pm
@@ -186,7 +186,7 @@ sub query_params { shift->url->query }
 
 sub _parse_basic_auth {
   return undef unless my $header = shift;
-  return $header =~ /Basic (.+)$/ ? b64_decode($1) : undef;
+  return $header =~ /Basic (.+)$/ ? b64_decode $1 : undef;
 }
 
 sub _parse_env {

diff --git a/lib/Mojo/Transaction/WebSocket.pm b/lib/Mojo/Transaction/WebSocket.pm
@@ -323,7 +323,7 @@ sub _message {
   $self->emit(json => j($msg)) if $self->has_subscribers('json');
   $op = delete $self->{op};
   $self->emit($op == TEXT ? 'text' : 'binary' => $msg);
-  $self->emit(message => $op == TEXT ? decode('UTF-8', $msg) : $msg)
+  $self->emit(message => $op == TEXT ? decode 'UTF-8', $msg : $msg)
     if $self->has_subscribers('message');
 }
 

diff --git a/lib/Mojolicious/Command/generate/plugin.pm b/lib/Mojolicious/Command/generate/plugin.pm
@@ -12,7 +12,7 @@ sub run {
   $name ||= 'MyPlugin';
 
   # Class
-  my $class = $name =~ /^[a-z]/ ? camelize($name) : $name;
+  my $class = $name =~ /^[a-z]/ ? camelize $name : $name;
   $class = "Mojolicious::Plugin::$class";
   my $app = class_to_path $class;
   my $dir = join '-', split('::', $class);

diff --git a/lib/Mojolicious/Command/inflate.pm b/lib/Mojolicious/Command/inflate.pm
@@ -17,8 +17,8 @@ sub run {
   for my $class (@{$app->renderer->classes}, @{$app->static->classes}) {
     for my $name (keys %{$loader->data($class)}) {
       my $data = $loader->data($class, $name);
-      $all{$name}
-        = $loader->is_binary($class, $name) ? $data : encode('UTF-8', $data);
+      $data = encode 'UTF-8', $data unless $loader->is_binary($class, $name);
+      $all{$name} = $data;
     }
   }
 

diff --git a/lib/Mojolicious/Plugin/DefaultHelpers.pm b/lib/Mojolicious/Plugin/DefaultHelpers.pm
@@ -33,7 +33,7 @@ sub register {
     for qw(content content_for csrf_token current_route delay),
     qw(inactivity_timeout is_fresh url_with);
 
-  $app->helper(dumper => sub { shift; dumper(@_) });
+  $app->helper(dumper => sub { shift; dumper @_ });
   $app->helper(include => sub { shift->render_to_string(@_) });
 
   $app->helper("reply.$_" => $self->can("_$_")) for qw(asset static);
@@ -72,7 +72,7 @@ sub _content_for {
 sub _csrf_token {
   my $c = shift;
   $c->session->{csrf_token}
-    ||= sha1_sum($c->app->secrets->[0] . steady_time . rand 999);
+    ||= sha1_sum $c->app->secrets->[0] . steady_time . rand 999;
 }
 
 sub _current_route {

diff --git a/lib/Mojolicious/Plugin/PODRenderer.pm b/lib/Mojolicious/Plugin/PODRenderer.pm
@@ -5,7 +5,7 @@ use Mojo::Asset::File;
 use Mojo::ByteStream 'b';
 use Mojo::DOM;
 use Mojo::URL;
-use Mojo::Util qw(slurp unindent url_escape);
+use Mojo::Util qw(slurp unindent);
 use Pod::Simple::XHTML;
 use Pod::Simple::Search;
 

diff --git a/lib/Mojolicious/Plugins.pm b/lib/Mojolicious/Plugins.pm
@@ -33,7 +33,7 @@ sub load_plugin {
   my ($self, $name) = @_;
 
   # Try all namespaces and full module name
-  my $suffix = $name =~ /^[a-z]/ ? camelize($name) : $name;
+  my $suffix = $name =~ /^[a-z]/ ? camelize $name : $name;
   my @classes = map {"${_}::$suffix"} @{$self->namespaces};
   for my $class (@classes, $name) { return $class->new if _load($class) }
 

diff --git a/lib/Mojolicious/Renderer.pm b/lib/Mojolicious/Renderer.pm
@@ -154,7 +154,7 @@ sub template_for {
   # Normal default template
   my $stash = $c->stash;
   my ($controller, $action) = @$stash{qw(controller action)};
-  return join '/', split('-', decamelize($controller)), $action
+  return join '/', split('-', decamelize $controller), $action
     if $controller && $action;
 
   # Try the route name if we don't have controller and action

diff --git a/lib/Mojolicious/Routes.pm b/lib/Mojolicious/Routes.pm
@@ -125,7 +125,7 @@ sub _class {
 
   # Application class
   my @classes;
-  my $class = $field->{controller} ? camelize($field->{controller}) : '';
+  my $class = $field->{controller} ? camelize $field->{controller} : '';
   if ($field->{app}) { push @classes, $field->{app} }
 
   # Specific namespace

diff --git a/lib/Mojolicious/Sessions.pm b/lib/Mojolicious/Sessions.pm
@@ -48,7 +48,7 @@ sub store {
   $session->{expires} = $default || time + $expiration
     if $expiration || $default;
 
-  my $value = b64_encode($self->serialize->($session), '');
+  my $value = b64_encode $self->serialize->($session), '';
   $value =~ y/=/-/;
   my $options = {
     domain   => $self->cookie_domain,