Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 605329d7f773
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 04b63e022a47
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Feb 10, 2015

  1. lib: fix max size check in Buffer constructor 

    A number -> uint32 type coercion bug made buffer sizes
larger than kMaxLength (0x3fffffff) wrap around.

Instead of rejecting the requested size with an exception,
the constructor created a buffer with the wrong size.

PR-URL: nodejs/node#657
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis @trevnorris
    bnoordhuis authored and trevnorris committed Feb 10, 2015
    Copy the full SHA
    04b63e0 View commit details
    Browse the repository at this point in the history