Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6fac61b468dc
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 040a6136d5f1
Choose a head ref
  • 11 commits
  • 103 files changed
  • 1 contributor

Commits on Feb 11, 2015

  1. Trivial: IDE de-warn

    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    2f6910d View commit details

  2. tCHAR is a string and not a numeric

    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    4827d56 View commit details

  3. All numeric Nodes in AST extend from the same NumericNode type. I am … 

    …propagating whether

subtrees have assignments in them and having more specific nodes makes it easier to know
whether I need to check whether it has an assignment or not in it (numeric types cannot).
    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    ac37012 View commit details

  4. Flow control nodes changed to never receive a null value. This simpli… 

    …fies truffle and IR

since it does not need to do implicit nil check AND a null check.
    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    77d5737 View commit details

  5. Whoops truffle part did not get committed

    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    d61bb39 View commit details

  6. Add hasAssignment to all nodes. To be used by IRBuilder (described in… 

    … next commit)
    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    8ce6a0c View commit details

  7. Strings should pass cr to avoid recalc'ing

    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    9d8dc51 View commit details

  8. Make hasAssignment hasVariableAssignment since it only refers to lvar… 

    …/dvars.

Use this new knowledge in IRBuilder to fix GH #2574.  Still some other cases
to fix.
    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    237fee2 View commit details

  9. Some more cases for GH #2574.

    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    075108f View commit details

  10. Ooof. I guess too many -pl core builds

    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    63cdbc4 View commit details

  11. Revert "Strings should pass cr to avoid recalc'ing" 

    3 mysterious errors to work through in test:mri.

This reverts commit 9d8dc51.
    @enebo
    enebo committed Feb 11, 2015
    Copy the full SHA
    040a613 View commit details
Loading