Add version label check for valid characters #711
Conversation
| * @param label label | ||
| * @return whether label contains valid characters | ||
| */ | ||
| public boolean invalidLabel(final String label) { |
There was a problem hiding this comment.
This method should be "private".
Also, I agree with the javadocs on this method, that it is more clear if the method returns whether the arg label is valid. Additionally, it would make the logic above easier to read, i.e. no double-negative. Instead it would read:
if (!isBlank(slug) && validLabel(slug)) {
I suggest renaming the method and returning !matcher.find()
There was a problem hiding this comment.
In looking at this closer, the label validation should be enforced even if the user does not make the request via the REST API. Therefore, you should move your updates deeper into the application, i.e. https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-kernel-impl/src/main/java/org/fcrepo/kernel/impl/services/VersionServiceImpl.java#L162
|
Resolved with: bb6072d |
https://jira.duraspace.org/browse/FCREPO-1246