Fix Excel export of plug-in columns limited to first 100 rows

dregad · dregad · commit e48ce931e2da · 2012-05-30T00:20:43.000+02:00
Due to an incorrect location of columns_plugin_cache_issue_data()
function call outside of the main loop, only the first 100 rows of
plug-in columns were loaded when exporting issues to Excel.

Thanks to vincent_sels for spotting the issue and identifying the root
cause.

Fixes #14185
diff --git a/excel_xml_export.php b/excel_xml_export.php
@@ -54,9 +54,6 @@
 		print_header_redirect( 'view_all_set.php?type=0&print=1' );
 	}
 
-	# pre-cache custom column data
-	columns_plugin_cache_issue_data( $result );
-
 	header( 'Content-Type: application/vnd.ms-excel; charset=UTF-8' );
 	header( 'Pragma: public' );
 	header( 'Content-Disposition: attachment; filename="' . urlencode( file_clean_name( $t_export_title ) ) . '.xml"' ) ;
@@ -69,6 +66,9 @@
 	$t_columns = excel_get_columns();
 
 	do {
+		# pre-cache custom column data
+		columns_plugin_cache_issue_data( $result );
+
 		foreach( $result as $t_row ) {
 			if ( is_blank( $f_export ) || in_array( $t_row->id, $f_bug_arr ) ) {
 				echo excel_get_start_row();
