Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 8bd23fbfe7a3
Choose a base ref
...
head repository: jruby/jruby
compare: ef5241481cd7
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Nov 5, 2014

  1. Add min/max/min_by/max_by optional argument support 

    Per issue #2099 - adds support for an optional argument which indicates
that the method should return an array of values corresponding to the top
n values. This is currently implemented as sort.first(n) or sort.last(n).reverse
and should be refactored to something that is O(n) memory rather than O(elems).
    @cheald
    cheald committed Nov 5, 2014
    Copy the full SHA
    e1f8c2a View commit details
    Browse the repository at this point in the history

  2. Return empty arrays when the optional arg is passed but the range is … 

    …empty.
    @cheald
    cheald committed Nov 5, 2014
    Copy the full SHA
    78dd322 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2101 from cheald/add_min_max_arg 

    Add min/max/min_by/max_by optional argument support
    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    ef52414 View commit details
    Browse the repository at this point in the history