Change generic exceptions to more specific exceptions #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO determine problems that should be runtime errors | ||
| } | ||
| } catch (Exception e) { | ||
| throw new RepositoryRuntimeException(e); |
There was a problem hiding this comment.
I may be being really too picky here, but to my understanding, this is not a RepositoryRuntimeException precisely because the repository is not running. We could put in a new RepositoryFailedStartup kind of thing, or maybe MODE already has such thing, or maybe I'm just being too picky...
There was a problem hiding this comment.
Sounds very reasonable. But since @osmandin does not appear to agree, let's move this through for now.
|
This is good stuff and I'm all in favor, but I do want to record here (for my own failing memory) that we probably ought to be subclassing |
awoods
pushed a commit
that referenced
this pull request
Feb 16, 2015
Change generic exceptions to more specific exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/FCREPO-1317?jql=key%20in%20(FCREPO-1317)
http://sonar.fcrepo.org/drilldown/issues/1?&rule=squid%3AS00112&rule_sev=MAJOR&severity=MAJOR#