Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 7ffc17afc94c
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 6e21bd059761
Choose a head ref
  • 4 commits
  • 110 files changed
  • 2 contributors

Commits on Feb 10, 2015

  1. lib: fix max size check in Buffer constructor

    A number -> uint32 type coercion bug made buffer sizes
    larger than kMaxLength (0x3fffffff) wrap around.
    
    Instead of rejecting the requested size with an exception,
    the constructor created a buffer with the wrong size.
    
    PR-URL: nodejs/node#657
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and trevnorris committed Feb 10, 2015
    Copy the full SHA
    04b63e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2015

  1. Copy the full SHA
    ecfc1a2 View commit details
    Browse the repository at this point in the history
  2. build: fix SmartOS build

    The -fno-strict-aliasing flag was added to fix compilation warnings when
    building Node.js with GCC <= 4.4
    trevnorris committed Feb 11, 2015
    Copy the full SHA
    eb41b0c View commit details
    Browse the repository at this point in the history
  3. lib: fix stdio/ipc sync i/o regression

    process.send() should be synchronous, it should block until the message
    has been sent in full, but it wasn't after the second-to-last libuv
    upgrade because of commit libuv/libuv@393c1c5 ("unix: set non-block
    mode in uv_{pipe,tcp,udp}_open"), which made its way into io.js in
    commit 07bd05b ("deps: update libuv to 1.2.1").
    
    Commit libuv/libuv@b36d4ff ("unix: implement uv_stream_set_blocking()")
    as landed in io.js in commit 9681fca ("deps: update libuv to 1.4.0")
    makes it possible to restore the synchronous behavior again and that's
    precisely what this commit does.
    
    The same line of reasoning applies to `net.Socket({ fd: 1 })`: creating
    a socket object from a stdio file descriptor, like the `process.stdout`
    getter does, should put the file descriptor in blocking mode for
    compatibility reasons.
    
    PR-URL: nodejs/node#774
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and trevnorris committed Feb 11, 2015
    Copy the full SHA
    6e21bd0 View commit details
    Browse the repository at this point in the history