Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various minor fix for AbstractLatentBuildSlave and DockerLatentBuildSlave #1365

Merged
merged 5 commits into from Nov 18, 2014

Conversation

delanne
Copy link
Contributor

@delanne delanne commented Nov 18, 2014

AbstractLatentBuildSlave:

  • Fix error with build_wait_timeout
    DockerLatentBuildSlave:
  • it doesn't work when max_build!=1 (concurrent build are violently canceled because the container is stopped) => Fix that
  • Fix: Support the build_wait_timeout feature (like all AbstractLatentBuildSlave child class)
  • Fix: remove the last \n of log lines when the docker image is built.
  • Fix: destroy the container when the container is stopped (Container are created on demande, there's no need to keep old container. the disk space will grow up!)
  • Create the container with the slave_name + id. docker ps is easier to read.

Xavier Delannoy added 5 commits November 18, 2014 12:11
 - Fix: create the container with the name <slavename>_<id>
 - Fix: destroy the container after the stop operation. (Eg: remove from disk)
 - remove the last \n of log lines when the docker image is built.
 - remove buildFinished method. It breaks at least:
   - a slave can run several build in parallel.
     with buildFinished, the container is removed as soon as the first build is finished. As a consequence, concurrent build are canceled.
     This is not what we want
   - build_wait_timeout feature
     This is implemented by AbstractLatentBuildSlave
…s tracback appears when the slave is disconnected when the build_wait_timer fired:

	Traceback (most recent call last):
	  File "/home/xavierd/Projects/myGitHub/buildbot-work/sandbox/local/lib/python2.7/site-packages/twisted/spread/pb.py", line 1341, in maybeLogout
	    fn()
	  File "/home/xavierd/Projects/myGitHub/buildbot-work/src/master/buildbot/pbmanager.py", line 177, in <lambda>
	    return (pb.IPerspective, persp, lambda: persp.detached(mind))
	  File "/home/xavierd/Projects/myGitHub/buildbot-work/src/master/buildbot/buildslave/protocols/pb.py", line 104, in detached
	    self.notifyDisconnected()
	  File "/home/xavierd/Projects/myGitHub/buildbot-work/src/master/buildbot/buildslave/protocols/base.py", line 43, in notifyDisconnected
	    self._disconnectSubs.deliver()
	--- <exception caught here> ---
	  File "/home/xavierd/Projects/myGitHub/buildbot-work/src/master/buildbot/util/subscription.py", line 37, in deliver
	    sub.callback(*args, **kwargs)
	exceptions.TypeError: _disconnected() takes exactly 1 argument (0 given)
@sa2ajj
Copy link
Contributor

sa2ajj commented Nov 18, 2014

👍

sa2ajj pushed a commit that referenced this pull request Nov 18, 2014
various minor fix for AbstractLatentBuildSlave and DockerLatentBuildSlave
@sa2ajj sa2ajj merged commit d527f19 into buildbot:master Nov 18, 2014
@delanne delanne deleted the DockerLatentFix branch October 20, 2015 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants