Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 73d328de2485
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 9c110d802762
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Aug 28, 2013

  1. vm: rip out ObjectWrap from ContextifyContext 

    This was a remnant of the original Contextify code, wherein
ContextifyContext was a user-exposed object. In vm, it is not, so all
of the ObjectWrap and function-template stuff for the ContextifyContext
constructor is now unnecessary.
    @domenic @bnoordhuis
    domenic authored and bnoordhuis committed Aug 28, 2013
    Copy the full SHA
    a54f65c View commit details
    Browse the repository at this point in the history

  2. vm: use MakeWeak to fix leaking contexts 

    This is always something you should do when using `SetHiddenValue`,
apparently. Fixes #6115. Thanks @tjfontaine for the tips.
    @domenic @bnoordhuis
    domenic authored and bnoordhuis committed Aug 28, 2013
    Copy the full SHA
    a3bf3d1 View commit details
    Browse the repository at this point in the history

  3. vm: add isContext; prevent double-contextifying 

    Previously, calling `vm.createContext(o)` repeatedly on the same `o`
would cause new C++ `ContextifyContext`s to be created and stored on
`o`, while the previous resident went off into leaked-memory limbo.
Now, repeatedly trying to contextify a sandbox will do nothing after
the first time.

To detect this, an independently-useful `vm.isContext(sandbox)` export
was added.
    @domenic @bnoordhuis
    domenic authored and bnoordhuis committed Aug 28, 2013
    Copy the full SHA
    9c110d8 View commit details
    Browse the repository at this point in the history