Refactor AuditableInterceptor to improve readibility. #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you still need to check that it is an OpenmrsObject or Person where necessary. |
|
I have looked at the rest of the file and it looks fine, ignore my last comment above |
|
In changePropertyValue, it checks to see if the object has the property that is being set. If it is a Person, it will have that property, if it isn't, then it won't update that Object. See line 165 in AuditableInterceptor, in the method changePropertyValue. I can extract this line to make this more clear, into a small method called "hasProperty", if you think it will make this more clear to anyone reviewing this file. |
dkayiwa
added a commit
that referenced
this pull request
Jan 29, 2014
Refactor AuditableInterceptor to improve readibility.
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored changes that were merged in #587.
Refactored for readability and to remove duplication in the code.
Original ticket- https://tickets.openmrs.org/browse/TRUNK-3964