TRUNK-4202 Convert Order.orderer to be a Provider #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rkorytkowski authored some way to test the entire upgrade, you can add tests to be sure, but you will do so after we merge the code |
| } | ||
|
|
||
| private String formatUser(User u) { |
There was a problem hiding this comment.
We need to keep formatUser, you should have just added formatProvider
|
@k-joseph i put several comments on this pull request around the sql queries that create providers and convert the orderer values and I mentioned that they looked incorrect to me and that is why the test is failing, you need to fix them to make the tests pass, please look closely at the tests and ensure you understand what they are testing, that way you will figure out what's wrong with the queries and fix them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k-joseph@TRUNK-4202