Commits on Jul 25, 2013

1. streams: Don't emit 'end' until read() past EOF …

   This prevents the following sort of thing from being confusing:
   
   ```javascript
   stream.on('data', function() { console.error('got data'); });
   stream.pause(); // stop reading
   
   // turns out no data is available
   stream.push(null);
   
   // Hand the stream to someone else, who does stuff...
   setTimeout(function() {
     // too late! 'end' is already emitted!
     stream.on('end', function() { console.error('got end'); });
   });
   ```
   
   With this change, the `end` event is not emitted until you call `read()`
   *past* the EOF null.  So, a paused stream will not swallow the `end`
   event and emit it before you `resume()` the stream.

   

   isaacs committed Jul 25, 2013
   Copy the full SHA

   993bb93 View commit details

   Browse the repository at this point in the history