Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morepmdstuff #63

Closed
wants to merge 8 commits into from
Closed

Morepmdstuff #63

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2014

Changes in method signatures did not require keeping the old methods with deprecations, as they were all private.

@johnmay
Copy link
Member

johnmay commented Sep 5, 2014

Pulled in all but the last commit as there is a large diff of DeduceBondSystemTool that looks erroneous. Just checking compilation and will push.

@johnmay johnmay closed this Sep 5, 2014
@johnmay johnmay reopened this Sep 5, 2014
@ghost
Copy link
Author

ghost commented Sep 5, 2014

Not sure what hoppened there - I'd been testing the new Eclipse formatter using the CDK configuration file in Netbeans, then switched back to Netbeans formatter - although I didn't reformat, there may have been a silent change as a side-effect. If there's a still a problem I'll take a look this evening...

From: John May
Sent: Friday, September 05, 2014 11:00 AM
To: cdk/cdk
Cc: mbv31602
Subject: Re: [cdk] Morepmdstuff (#63)

Pulled in all but the last commit as there is a large diff of DeduceBondSystemTool that looks erroneous. Just checking compilation and will push.


Reply to this email directly or view it on GitHub.

@johnmay
Copy link
Member

johnmay commented Sep 8, 2014

Okay managed to strip out the DeduceBondSystemTool changes... now all applied

@johnmay johnmay closed this Sep 8, 2014
@ghost ghost deleted the morepmdstuff branch September 27, 2014 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant