Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 5ff59453a483
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 8032a210250c
Choose a head ref
  • 5 commits
  • 3 files changed
  • 1 contributor

Commits on Nov 19, 2014

  1. doc: document the fds behind stdin/out/err 

    Its common knowledge on unix, but node documentation depends on knowing
this, as it exposes both streams named after stdio, and the fd numbers,
so make this explicit.

Fixes: #8624
PR-URL: #8454
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @sam-github @trevnorris
    sam-github authored and trevnorris committed Nov 19, 2014
    Copy the full SHA
    13a992b View commit details
    Browse the repository at this point in the history

  2. test: use assert.throw to test exceptions 

    The test wasn't checking directly that an assertion was thrown. Instead,
it was checking that spawn did not sucessfully spawn a non-existent
command.

However, the command chosen, dir, exists in GNU coreutils, so it exists
on Linux (though not on BSD derived OS X). The test as written passed on
Linux, even with the TypeError it is supposed to be checking for deleted
from spawn(). It would also pass on Windows if a ls.exe existed.

The approach is unnecessarily obscure, assert.throw() is for asserting
code throws, using it is more clear and works regardless of what
commands do or do not exist.

PR-URL: #8454
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @sam-github @trevnorris
    sam-github authored and trevnorris committed Nov 19, 2014
    Copy the full SHA
    2ff29cc View commit details
    Browse the repository at this point in the history

  3. child_process: check execFile args is an array 

    execFile and spawn have same API signature with respect to optional arg
array and optional options object, they should have same behaviour with
respect to argument validation.

PR-URL: #8454
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @sam-github @trevnorris
    sam-github authored and trevnorris committed Nov 19, 2014
    Copy the full SHA
    e17c5a7 View commit details
    Browse the repository at this point in the history

  4. child_process: check fork args is an array 

    Optional fork args should be type-checked with same behaviour as the
equivalent argument to spawn.

PR-URL: #8454
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @sam-github @trevnorris
    sam-github authored and trevnorris committed Nov 19, 2014
    Copy the full SHA
    70dafa7 View commit details
    Browse the repository at this point in the history

  5. test: test all spawn parameter positions 

    PR-URL: #8454
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @sam-github @trevnorris
    sam-github authored and trevnorris committed Nov 19, 2014
    Copy the full SHA
    8032a21 View commit details
    Browse the repository at this point in the history