Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchy #362

Closed
wants to merge 2 commits into from
Closed

Hierarchy #362

wants to merge 2 commits into from

Conversation

lsitu
Copy link
Contributor

@lsitu lsitu commented May 15, 2014

https://www.pivotaltracker.com/s/projects/684825/stories/71230608
I've added the generic support to the HierarchyConverter to handle the outgoing/incoming paths that include namspaces like jcr:system/jcr:versionStorage, which were brought up in "curl -v XPUT http://localhost:8080/rest/book”. The -v option above brought up a three hierarchy segments JCR path which did't match our default 4 levels hierarchy conversion, something like "jcr:system/jcr:versionStorage/69/8c/d6/698cd66f6a49f6a72fe740b0304c82ed977237d9/1.1". The "curl -v XPUT http://localhost:8080/rest/book” command should be working as expectation now.
I also fixed the NullPointerError that were triggered during running the tests and enabled all the existing tests cases in FedoraNotesTest.java and FedoraContentTest.hava for transparent hierarchy support.

lsitu added 2 commits May 15, 2014 10:05
namespaces that occurs in the path like jcr:system, jcr:versionStorage,
jcr:content etc.
FedoraNodesTest.java and FedoraContentTest.java for transparent
hierarchy support.
@@ -70,6 +68,9 @@ public String apply(final String input) {

private static final Logger log = getLogger(HierarchyConverter.class);

private static final String JCR_NASPACE_PREFIX = "jcr";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, should be "NAMESPACE"

@awoods
Copy link

awoods commented May 19, 2014

Split into to other commits:
f3ba1eb and
e629670

@awoods awoods closed this May 19, 2014
@lsitu lsitu deleted the hierarchy branch May 20, 2014 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants