Shutdown hook #476
Closed
Shutdown hook #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Retrieves the application context in which it is configured, for testing | ||
| * purposes only. | ||
| * | ||
| * @author Gregory Jansen |
There was a problem hiding this comment.
Add @SInCE class annotation
...apparently that did not make it into our checkstyles.
Edits to repo.xml files reflect the new ModeShapeEngine and destroy hook on ModeShapeRepositoryFactoryBean Retooled several ITs to create just a container context and get at beans via singleton pattern Some ITs were starting two repositories (in two different application contexts)
mikedurbin
force-pushed
the
shutdown-hook
branch
from
5d2c74c
to
f40827c
Compare
|
Resolved with: 4762faa Addresses: https://www.pivotaltracker.com/story/show/66454096 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost exclusively Greg's work.
I tested it and reintroduced a unit test by adding more mocking.
I looked at ModeShape and the calls we're making to ModeShapeEngine appear to be the same that the JcrRepositoryFactory made.
I have pull requests for fcrepo-message-receiver, fcrepo-module-auth-rbacl and fcrepo-module-auth-xacml that simply change the spring configurations in the way that has been done in this project.
See PR #260 for earlier commentary or the ticket in pivotal.
https://www.pivotaltracker.com/story/show/66454096