Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 7ce5a310612b
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 49e3fcd05852
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on May 30, 2013

  1. vm: fix race condition in watchdog cleanup 

    Previous code was calling uv_loop_delete() directly on a running loop,
which led to race condition aborts/segfaults within libuv.  This change
changes the watchdog thread to call uv_run() with UV_RUN_ONCE so that
the call exits after either the timer times out or uv_async_send() is
called from the main thread in Watchdog::Destroy().  The timer/async
handles are then closed and uv_run() with UV_RUN_DEFAULT is called so
that libuv has a chance to cleanup before the thread exits.  The main
thread meanwhile calls uv_thread_join() and then uv_loop_delete() to
complete the cleanup.
    @apaprocki @bnoordhuis
    apaprocki authored and bnoordhuis committed May 30, 2013
    Copy the full SHA
    49e3fcd View commit details
    Browse the repository at this point in the history