You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
It looks like someone didn't test their code before pushing! Haha sorry, don't mean to be critical. I just noticed because my last pull was at the commit before this. This is why I don't like using commas for multiple variable definitions. It can lead to stuff like that, and if you forget a comma the code still runs and you end up creating unwanted GLOBAL variables.
The reason will be displayed to describe this comment to others. Learn more.
I really don't want to bikeshed on this. We use one var statement per scope in this module. The typo fixed before the version was pushed out, you shouldn't be running against master if you can help it. Thank you again for your contribution!
3f19e6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like someone didn't test their code before pushing! Haha sorry, don't mean to be critical. I just noticed because my last pull was at the commit before this. This is why I don't like using commas for multiple variable definitions. It can lead to stuff like that, and if you forget a comma the code still runs and you end up creating unwanted
GLOBAL
variables.3f19e6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't want to bikeshed on this. We use one
var
statement per scope in this module. The typo fixed before the version was pushed out, you shouldn't be running againstmaster
if you can help it. Thank you again for your contribution!